search

svalinn / Cubit-plugin

Plugins and command extensions for Coreform Cubit
BSD 3-Clause "New" or "Revised" License
17 stars 14 forks source link

Building ubuntu and debian inside docker #115

Closed shimwell closed 3 years ago

shimwell commented 3 years ago

Following on from the last DAGMC meeting here is a PR that attempts to build the plugin for debian 10.10

The approach taken is to use a docker container to build linux flavours (ubuntu 21.04, ubuntu 20.04, debian 10.10) and to use the base github actions (without a docker container) to build for mac os.

This appears to work given the constraints:

This appears to help with #112 as the plugin can be build for a few more OS and OS versions.

shimwell commented 3 years ago

Everything appears to be building 🎉 thanks @bam241 for getting this started

shimwell commented 3 years ago

I've addressed all the suggestions and done as recommended, thanks for the review. Let's see how it does with the CI building process.

shimwell commented 3 years ago

A few changes to clean things up.

At some point we should review the overall design to increase reuse of things rather than maintaining different scripts.

Sounds like a good plan, I think once GH actions allows containers of Mac OS there is some recombination that can be done

bam241 commented 3 years ago

There some issues with the plug-in artifacts uploads: https://github.com/svalinn/Cubit-plugin/actions/runs/1114012215 And:

https://github.com/svalinn/Cubit-plugin/actions/runs/1114012218

One also can test those individually to ensure they are working as intended :)

bam241 commented 3 years ago

I meant test them locally

bam241 commented 3 years ago

A few changes to clean things up.

At some point we should review the overall design to increase reuse of things rather than maintaining different scripts.

Sounds like a good plan, I think once GH actions allows containers of Mac OS there is some recombination that can be done

This is very unlikely to happen as it will broken general usage conditions of MacOS: you can only use macOS on a Mac machine... I.e. virtualization of macOS is only allowed on a Mac host.... allowing it on docker will imply requiring a lot of safeguards on the docker implementation side to make sure you cannot run a macOS is on a non-Mac host... Multi-platform virtualizer apps tended to stay away from those complication in the past

shimwell commented 3 years ago

Looks like Trelis 17.1.0 is failing on Ubuntu 21.04 due to not finding HDF5

Could NOT find HDF5 (missing: HDF5_LIBRARIES HDF5_INCLUDE_DIRS) (found version "")

This was not actually build previously so I shall add it to the exclude list.

Perhaps it is fair to exclude combinations of old cubit with new os or vice versa

Ubuntu 20.04 with Cubit 17.0.1 was previously excluded, so I think it is reasonable to also exclude 21.04 with this version of Cubit

shimwell commented 3 years ago

Builds are passing for all the combinations 🎉

gonuke commented 3 years ago

Thanks @Shimwell - this gives us a good starting point to refine and grow