search

svalinn / Cubit-plugin

Plugins and command extensions for Coreform Cubit
BSD 3-Clause "New" or "Revised" License
17 stars 14 forks source link

add mac os for all cubit versions #117

Closed shimwell closed 3 years ago

shimwell commented 3 years ago

While chatting with @andergray we noticed Cubit Plugin was not available for Mac OS 11

It looks like Mac OS 11 is available as a runner so I thought it is worth trying to build on that OS

https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners

shimwell commented 3 years ago

Ah sorry I just noticed The macOS 11 virtual environment is currently provided as a private preview only so this PR can be parked till that OS becomes more widely available.

bam241 commented 3 years ago

I am not sure this is necessary. So far we have build on only 1 macOS version but the build were tested and used on multiples (at least 2 that I now of...)

Maybe the only things to do is to rename the tarball

shimwell commented 3 years ago

The existing Mac OS plugin has been tested on 10.15 and 11 to some extent and therefore has been renamed in PR #121 which mainly negates the need for this PR