search

svalinn / Cubit-plugin

Plugins and command extensions for Coreform Cubit
BSD 3-Clause "New" or "Revised" License
17 stars 14 forks source link

Mac OS build failing on GH actions #120

Closed shimwell closed 3 years ago

shimwell commented 3 years ago

After triggering the recent release at the DAGMC meeting I noticed that the Mac OS builds failed

https://github.com/svalinn/Cubit-plugin/runs/3372537266?check_suite_focus=true

It failed on the DAGMC build with the message fatal error: too many errors emitted, stopping now [-ferror-limit=]

gonuke commented 3 years ago

I'm pretty sure this is due to changes in DAGMC that is not being tested for MacOS

gonuke commented 3 years ago

An effort is underway to address this

bam241 commented 3 years ago

this is fixed in both coming PR svalinn/dagmc#727 and svalinn/dagmc#780

DAGMC.cpp is missing and #include <array> I guess windows and Mac compile are less permissive than the linux ones :)

bam241 commented 3 years ago

The fix has been merged svalinn/DAGMC#780. I restarted the release action for Mac. this should allow to upload the correct packages. closing when everything is confirmed as passed

bam241 commented 3 years ago

the Mac workflow worked as expected. closing.