svalinn / Cubit-plugin

Plugins and command extensions for Coreform Cubit
BSD 3-Clause "New" or "Revised" License
17 stars 14 forks source link

adding 2022.6 version on build workflow #135

Closed bam241 closed 2 years ago

bam241 commented 2 years ago

adding 2022.6 in the version stack

bam241 commented 2 years ago

conclusion of the quick test: Linux build seems to work for all version MacOS workflow is out-of-date. we need to update it be faire testing anything Windows seems to have some issue with building MOAB, this might only be related to 2022.6, I'll run more test to figure this out

bam241 commented 2 years ago

Windows seems to have some issue with building MOAB, this might only be related to 2022.6, I'll run more test to figure this out

All windows workflows are broken on MOAB build

gonuke commented 2 years ago

Mac is failing because of a deprecated call to finite(). MOAB tries to invoke the correct instance of this function, given that apparently many exist - see MOAB's Util.hpp.

It appears that we may not have access to the MOAB_HAVE_ISFINITE macro, either because we are not accessing the file that sets this (less likely because other things would fail) or that our CMake build of MOAB fails to set this in the config file we do access. This may need MOAB updates.

bam241 commented 2 years ago

I don't believe this is the right diagnostic. I think you were looking at the build that was cancelled because the build 2021.11 failed:

Run ${system}_build_plugin_pkg 2021.11
[21](https://github.com/svalinn/Cubit-plugin/runs/7456715236?check_suite_focus=true#step:11:22)
+ mac_build_plugin_pkg 2021.11
[22](https://github.com/svalinn/Cubit-plugin/runs/7456715236?check_suite_focus=true#step:11:23)
+ cd /Users/runner/work/Cubit-plugin/Cubit-plugin/..
[23](https://github.com/svalinn/Cubit-plugin/runs/7456715236?check_suite_focus=true#step:11:24)
+ mkdir -p pack/MacOS/plugins/svalinn
[24](https://github.com/svalinn/Cubit-plugin/runs/7456715236?check_suite_focus=true#step:11:25)
+ cd pack/MacOS/plugins/svalinn
[25](https://github.com/svalinn/Cubit-plugin/runs/7456715236?check_suite_focus=true#step:11:26)
+ cp -pPv /Users/runner/work/Cubit-plugin/Cubit-plugin/../lib/libiGeom.dylib /Users/runner/work/Cubit-plugin/Cubit-plugin/../lib/libmcnp2cad.dylib /Users/runner/work/Cubit-plugin/Cubit-plugin/../lib/libsvalinn_plugin.so .
[26](https://github.com/svalinn/Cubit-plugin/runs/7456715236?check_suite_focus=true#step:11:27)
/Users/runner/work/Cubit-plugin/Cubit-plugin/../lib/libiGeom.dylib -> ./libiGeom.dylib
[27](https://github.com/svalinn/Cubit-plugin/runs/7456715236?check_suite_focus=true#step:11:28)
+ cp /usr/local/opt/szip/lib/libsz.2.dylib .
[28](https://github.com/svalinn/Cubit-plugin/runs/7456715236?check_suite_focus=true#step:11:29)
/Users/runner/work/Cubit-plugin/Cubit-plugin/../lib/libmcnp2cad.dylib -> ./libmcnp2cad.dylib
[29](https://github.com/svalinn/Cubit-plugin/runs/7456715236?check_suite_focus=true#step:11:30)
/Users/runner/work/Cubit-plugin/Cubit-plugin/../lib/libsvalinn_plugin.so -> ./libsvalinn_plugin.so
[30](https://github.com/svalinn/Cubit-plugin/runs/7456715236?check_suite_focus=true#step:11:31)
cp: /usr/local/opt/szip/lib/libsz.2.dylib: No such file or directory
[31](https://github.com/svalinn/Cubit-plugin/runs/7456715236?check_suite_focus=true#step:11:32)
Error: Process completed with exit code 1.

the other ones stopped with : Error: The operation was canceled.

bam241 commented 2 years ago

I think one needs to investigate this: cp: /usr/local/opt/szip/lib/libsz.2.dylib: No such file or directory

bam241 commented 2 years ago

Mac build works, one need to test it. Linux build is failing, because of some connection issue, I don't think that comes from us.

bam241 commented 2 years ago

@gonuke what do we want to do with the Windows build ?

it seems that HDF5 is not playing nicely with MOAB any more.... It would probably be a quick/easy fix, but I don't have the hardware to test it anymore....

bam241 commented 2 years ago

@gonuke what is the plan there ?

Do we want to include the windows fix in there as well ?

gonuke commented 2 years ago

I think we can go ahead without the windows fix since we don't have a good place to develop that at the moment

gonuke commented 2 years ago

Since I just merged @shimwell 's PR with the Readme table, can you rebase and update that, please?

gonuke commented 2 years ago

Actually, maybe this doesn't need a rebase

gonuke commented 2 years ago

Merging this now - the updated table in the Readme should come with a release.