svalinn / Cubit-plugin

Plugins and command extensions for Coreform Cubit
BSD 3-Clause "New" or "Revised" License
17 stars 14 forks source link

fixing macos 2022.4 plugin #144

Closed bam241 closed 1 year ago

bam241 commented 1 year ago

this should allow add the missing lib and to correct its @rpath in the plugin library

bam241 commented 1 year ago

this should fix #143 for 2022.4 cc @veeshy

once it is build you should be able to find a new version of the plugin in the build artifacts. For your specific version here: https://github.com/svalinn/Cubit-plugin/actions/runs/3712499162

bam241 commented 1 year ago

@veeshy the new build seems to be working for me

could you confirm ?

(Non-Commercial License) Cubit>help export dagmc

Help for words: export & dagmc.

export dagmc <filename> [faceting_tolerance <faceting tolerance>] [length_tolerance <length tolerance>]
     [normal_tolerance <normal tolerance>] [make_watertight] [verbose]
     [fatal_on_curves]

Help for words: export & dagmc.

export dagmc <filename> [faceting_tolerance <faceting tolerance>] [length_tolerance <length tolerance>]
     [normal_tolerance <normal tolerance>] [make_watertight] [verbose]
     [fatal_on_curves]
veeshy commented 1 year ago

Can confirm it works for me

bam241 commented 1 year ago

Great.

Could you take a look @gonuke ?

bam241 commented 1 year ago

@gonuke, sorry it took me so long.

next time, if there is just a small suggestion like that, feel free to commit it, and merge it, so this doesn't have to wait for me and my limited availability....

bam241 commented 1 year ago

ping @gonuke ?

gonuke commented 1 year ago

Thanks @bam241 - LGTM!