search

svalinn / Cubit-plugin

Plugins and command extensions for Coreform Cubit
BSD 3-Clause "New" or "Revised" License
17 stars 14 forks source link

inconsistencies between Trelis 17.1 and 16.5 #70

Closed bam241 closed 4 years ago

bam241 commented 4 years ago

I just found out issues with building the plugin with 16.5.

SDK are not packeted the same way (Trelis/bin vs bin/)

find_package(Cubit REQUIRED CONFIG) do not work I had to use: find_package(Cubit) instead (It still complained that Cubit was not found, but the plugin I build was working anyway....

bam241 commented 4 years ago

here is the error I see:

CMake Error at CMakeLists.txt:40 (find_package):
  Found package configuration file:

    /opt/Trelis-16.5/bin/CubitConfig.cmake

  but it set Cubit_FOUND to FALSE so package "Cubit" is considered to be NOT
  FOUND.  Reason given by package:

  The following imported targets are referenced, but are missing:
  showviz_base

-- Configuring incomplete, errors occurred!
makeclean commented 4 years ago

The .cmake files are broken, this was true in trelis 16.5 too, if you remove showviz from the offending .cmake files it will work fine

From: Baptiste Mouginot notifications@github.com Sent: Thursday, October 29, 2020 2:18:41 PM To: svalinn/Trelis-plugin Trelis-plugin@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [svalinn/Trelis-plugin] inconsistencies between Trelis 17.1 and 16.5 (#70)

here is the error I see:

CMake Error at CMakeLists.txt:40 (find_package): Found package configuration file:

/opt/Trelis-16.5/bin/CubitConfig.cmake

but it set Cubit_FOUND to FALSE so package "Cubit" is considered to be NOT FOUND. Reason given by package:

The following imported targets are referenced, but are missing: showviz_base

-- Configuring incomplete, errors occurred!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/svalinn/Trelis-plugin/issues/70#issuecomment-718783512, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AASTUSVNEQVF3SSKL5VCT2LSNF2UDANCNFSM4TC22TGA.

pshriwise commented 4 years ago

Indeed. We got this sorted out this morning. There's also a provided note from @ljacobson64 in the README on this. I think that's the best we can do for now. Closing...