updated the build script

[makeclean]

There are probably bigger sustainability questions about how we deal with the new micro releases, but this is what I did to make it work.

[bam241]

I have only 1 comments to enable GitHub action to work.

have you tried it for 2021.3 as well ?

thx a lot @makeclean

[MigMagan]

A couple of changes that seem to be needed...

OS name detection is not working here

index d23b327..f7c714d 100644
--- a/scripts/unix_share_build.sh
+++ b/scripts/unix_share_build.sh
@@ -55,11 +55,10 @@ function setup_var() {
         echo "unknown Trelis/Cubit version"
         return 1
     fi
-
-    if [ "OS" == "MAC" ]; then
+    if [ $OS == "MAC" ]; then
         BUILD_SHARED_LIBS="OFF"
         BUILD_STATIC_LIBS="ON"
-    elif [ "OS" == "UBUNTU"]; then
+    elif [ $OS == "UBUNTU" ]; then
         BUILD_SHARED_LIBS="ON"
         BUILD_STATIC_LIBS="OFF"

Name of the function seems outdated

index 55d68bc..2467b17 100755
--- a/scripts/build_plugin_linux.sh
+++ b/scripts/build_plugin_linux.sh
@@ -25,19 +25,23 @@ SED="sed"
 source ${SCRIPTPATH}/scripts/unix_share_build.sh

-build_hdf5
+linux_build_hdf5

Also, I noticed that the plugin builds againts libMOAB.so.0, while the lib file is named libMOAB.so.5. I just linked it, and after that, the plugin is working with 2021.3 !

[gonuke]

Do we need all three of these workflow files? or does unix replace linux and macos?

[bam241]

Do we need all three of these workflow files? or does unix replace linux and macos?

no I kept them to help me unifying them.

we will only keep the unix.yml one

[bam241]

A couple of changes that seem to be needed...

OS name detection is not working here

index d23b327..f7c714d 100644
--- a/scripts/unix_share_build.sh
+++ b/scripts/unix_share_build.sh
@@ -55,11 +55,10 @@ function setup_var() {
         echo "unknown Trelis/Cubit version"
         return 1
     fi
-
-    if [ "OS" == "MAC" ]; then
+    if [ $OS == "MAC" ]; then
         BUILD_SHARED_LIBS="OFF"
         BUILD_STATIC_LIBS="ON"
-    elif [ "OS" == "UBUNTU"]; then
+    elif [ $OS == "UBUNTU" ]; then
         BUILD_SHARED_LIBS="ON"
         BUILD_STATIC_LIBS="OFF"

Name of the function seems outdated

index 55d68bc..2467b17 100755
--- a/scripts/build_plugin_linux.sh
+++ b/scripts/build_plugin_linux.sh
@@ -25,19 +25,23 @@ SED="sed"
 source ${SCRIPTPATH}/scripts/unix_share_build.sh

-build_hdf5
+linux_build_hdf5

Also, I noticed that the plugin builds againts libMOAB.so.0, while the lib file is named libMOAB.so.5. I just linked it, and after that, the plugin is working with 2021.3 !

@MigMagan thx for your feedback.

the OS is not supposed to be a detection but a variable set by the user (see the updated comments), also I haven't try to script yet, I was focussing on the GitHub action build...

about the libMOAB.so, I am unsure about what you mean by linked it, but it should be included in the plugin folder as we import ${PLUGIN_ABS_PATH}/moab/lib/libMOAB.so*...

[bam241]

@makeclean @gonuke @pshriwise this should be ready for a extensive review.

I also included a merge of the linux and Mac GitHub action into unix GitHub action.

I only included the 17.1.0 and 2021.4 version yet as this is the only version we have both .deb for ubuntu and .dmg for Mac ...

note that 2021.5 has just been released.....