search

svalinn / Cubit-plugin

Plugins and command extensions for Coreform Cubit
BSD 3-Clause "New" or "Revised" License
17 stars 14 forks source link

Removing Trelis mention #98

Closed bam241 closed 3 years ago

bam241 commented 3 years ago

converting Trelis mention to Cubit.

This should probably come with a repo renaming

bam241 commented 3 years ago

some mention are still present in scripts and mcnp2cad

the scripts one should done after #86 that take care of some of them.

a sperate PR is required for mcnp2cad

bam241 commented 3 years ago

I made one comment outside of this review, but I think this looks OK. I assume it's failing tests because the repo has not been renamed?

Yes:

/home/runner/work/Trelis-plugin/Trelis-plugin/scripts/unix_share_build.sh: line 199: cd: Cubit-plugin: No such file or directory
gonuke commented 3 years ago

Should we announce a plan to rename the repo and then rename it before merging this?

bam241 commented 3 years ago

yes I was thinking on using Thursday meeting for this

pshriwise commented 3 years ago

This now has some conflicts after merging #97. I'd be happy to review it as soon as they are resolved.

gonuke commented 3 years ago

We also need to stage this for the change in repo name

bam241 commented 3 years ago

@pshriwise @gonuke this has been rebased. let's discuss Thursday about the course of actions for this.

bam241 commented 3 years ago

@gonuke @pshriwise this is ready for a last run of review or a merge !