search

svalinn / DAGMC

Direct Accelerated Geometry Monte Carlo Toolkit
https://svalinn.github.io/DAGMC
Other
104 stars 65 forks source link

Complete the PyNE Tally Class #413

Open makeclean opened 8 years ago

makeclean commented 8 years ago

The Tally class was originally implemented to allow an arbitrary particle from the pyne::particle class to be used in a pyne::tally object, it was envisioned originally that this would end up with allowing us to use Cubit/Trelis groups in the following style

tally:Neutron/DPA tally:Photon/Heat tally:Proton/Dose tally:Neutron/HeProd etc

These particle type/tally type pairs would have to figure out a number of things, for example

What I imagine for the case of DPA, we can use material object metadata to store the displacement energy on material by material basis, i.e this must already set in the material object at runtime, perhaps we can assume the average for most materials (40 eV) as a default but warn that otherwise it isn't set.

For tally types that require the material number, by the time we write the lcad file, we know what the material number for each cell is, and therefore we can determine the appropriate material number for say an FM card in the case of MCNP

gonuke commented 6 years ago

Is this a DAGMC issue or a PyNE issue, or should there be matching issues in each place?

shimwell commented 6 years ago

Andy has made some progress on this and in particular getting the material number through to the MCNP file. TBR, DPA, HEAT are partly done at the moment.

gonuke commented 6 years ago

Small PRs would a great way to get this added in....

shimwell commented 6 years ago

We have started with a fork and have a few more bits to figure out and check. But for now it is forked here

Hope to make the PR soon.

shimwell commented 6 years ago

Perhaps a separate issue but I think at some point the unstructured mesh tallies should also be added to the tetmesh produced in trelis/cubit as groups.