search

svalinn / DAGMC

Direct Accelerated Geometry Monte Carlo Toolkit
https://svalinn.github.io/DAGMC
Other
97 stars 63 forks source link

Update version strings for release #785

Closed gonuke closed 2 years ago

gonuke commented 2 years ago

Updated version strings for release in two canonical places.

shimwell commented 2 years ago

regarding the outstanding task, is that similar to the submodules that Bam was working on in PR #742

gonuke commented 2 years ago

regarding the outstanding task, is that similar to the submodules that Bam was working on in PR #742

I don't think so???? We simply need to advance the hash that our submodule refers to now that we have a hash that points to a release (candidate)

gonuke commented 2 years ago

regarding the outstanding task, is that similar to the submodules that Bam was working on in PR #742

I don't think so???? We simply need to advance the hash that our submodule refers to now that we have a hash that points to a release (candidate)

However, I need to wait for the PyNE RC PR to be merged

shimwell commented 2 years ago

regarding the outstanding task, is that similar to the submodules that Bam was working on in PR #742

I don't think so???? We simply need to advance the hash that our submodule refers to now that we have a hash that points to a release (candidate)

However, I need to wait for the PyNE RC PR to be merged

Just merged PyNE RC 0.7.6

gonuke commented 2 years ago

I just updated PyNE but noticed that we don't run a full set of CI on that change.... stay tuned...

gonuke commented 2 years ago

Good thing we're waiting - the new PyNE version string stuff broke DAGMC builds!

gonuke commented 2 years ago

Since this is a PR to a non-develop branch, it doesn't run tests, but successful tests can be found here: https://github.com/gonuke/DAGMC/actions

pshriwise commented 2 years ago

Will merge at EOB today if there are no further comments.