Require minimum version of MOAB

svalinn / DAGMC

Direct Accelerated Geometry Monte Carlo Toolkit

https://svalinn.github.io/DAGMC

Other

103 stars 65 forks source link

Require minimum version of MOAB #788

Open gonuke opened 2 years ago

gonuke commented 2 years ago

We should assert a minimum version of MOAB that is necessary for compatibility. However, MOAB does not currently report its version number in the CMake infrastructure, so we don't have a good way to check.

A PR has been launched into MOAB to add this (https://bitbucket.org/fathomteam/moab/pull-requests/571) so this issue can be addressed when that is released, hopefully v5.3.2 or 5.4

This will hopefully just require an update to the find_package call in our CMake to specify the minimum version

pshriwise commented 2 years ago

@gonuke was this resolved in MOAB? I see your PR went in and was potentially replaced by another, but I couldn't track a replacement PR down.

gonuke commented 2 years ago

I don't think so. There has not been a release since this issue was posted.

gonuke commented 2 years ago

I think there are just bigger issues in MOAB's build infrastructure. I seem to recall that this PR may have motivated a discussion about moving to CMake as the primary build system for MOAB, though?

ahnaf-tahmid-chowdhury commented 8 months ago

It seems the PR is closed. Should we still consider setting the minimum version of MOAB to 5.4?

gonuke commented 8 months ago

Does MOAB now report a version number that can be queried by FindMOAB or similar in CMake?

ahnaf-tahmid-chowdhury commented 8 months ago

Sorry, I don't know.