search

svalinn / DAGMC

Direct Accelerated Geometry Monte Carlo Toolkit
https://svalinn.github.io/DAGMC
Other
103 stars 65 forks source link

Ensure PYTHONPATH and pymoab install directory are present for Linux CI builds #804

Closed pshriwise closed 2 years ago

pshriwise commented 2 years ago

Description

This adds the installation directory of PyMOAB to the PYTHONPATH env var in the linux builds used in CI. It also ensures that the installation directory is present by explicitly creating that directory before building MOAB.

I recognize that this is a band-aid, but the root problem is almost certainly upstream in MOAB and that will take time to remedy.

Motivation and Context

CI is broken.

Changelog file

~I don't think this change really warrants an entry in the changelog, but I will add one if requested.~

EDIT: Nevermind I guess we require a changelog check.

gonuke commented 2 years ago

Yikes... When I first looked at this, I couldn't figure out how it made a difference... and then I tried my own PR...

Thanks for this band-aid @pshriwise