svalinn / DAGMC

Direct Accelerated Geometry Monte Carlo Toolkit
https://svalinn.github.io/DAGMC
Other
96 stars 63 forks source link

Graveyard updates #855

Closed pshriwise closed 1 year ago

pshriwise commented 1 year ago

Description

These changes update some behavior of the DagMC::create/remove_graveyard function.

create_graveyard

remove_graveyard

There's a bug when calling create_graveyard with overwrite == true when a graveyard is not present. Previously, this would fail when trying to remove a graveyard that isn't present. This adds a check at the beginning of remove_graveyard to simply return MB_SUCCESS if no graveyard is present.

makeclean commented 1 year ago

Should we ever replace an existing graveyard? Should we just not add another to the set?

pshriwise commented 1 year ago

Should we ever replace an existing graveyard? Should we just not add another to the set?

I can see someone wanting to replace a spherical shell graveyard in case they're learning DAGMC and didn't realize how many triangles this might add to their model without having to re-tessellate the entire thing. Granted, some kind of utility program in the repo would be better than writing it yourself own, which is what they'd have to now.

gonuke commented 1 year ago

I'm ready to merge but want to give @makeclean a chance to either withdraw or amplify his concern?

gonuke commented 1 year ago

Thanks @pshriwise