Closed gonuke closed 1 year ago
This is failing windows tests @pshriwise - but it's probably not because of this PR... I've addressed your questions, so let me know if you think it's ready to merge.
This is failing windows tests @pshriwise - but it's probably not because of this PR... I've addressed your questions, so let me know if you think it's ready to merge.
Yes, I have also faced a similar problem in my PR #860. I am not sure, but I am assuming there is a bug in MOAB.
Its a build failure due to Gtest bizzarely
D:\a\DAGMC\DAGMC\src\gtest\gtest-1.8.0\src/gtest-internal-inl.h(641,31): error C2039: 'SetUpTestCaseFunc': is not a member of 'testing::Test' [D:\a\DAGMC\build\src\gtest\gtest.vcxproj]
Its a build failure due to Gtest bizzarely
D:\a\DAGMC\DAGMC\src\gtest\gtest-1.8.0\src/gtest-internal-inl.h(641,31): error C2039: 'SetUpTestCaseFunc': is not a member of 'testing::Test' [D:\a\DAGMC\build\src\gtest\gtest.vcxproj]
Dear @makeclean, I have updated gtest to v1.13.0 and found the same error. Here is the log.
Dear @gonuke, I believe that some of the resolved changes might have been accidentally dropped in the latest force-push. Could you please check?
Dear @gonuke, I believe that some of the resolved changes might have been accidentally dropped in the latest force-push. Could you please check?
Oh no! You may be right! Let me see if I can recover them manually
Converted this to draft until #880 is merged
This has been rebased & tested (over-tested for now since it's only a doc change) and ready to merge once @pshriwise approves changes.
@ahnaf-tahmid-chowdhury I'm happy with this if you are. If you don't have any further comments, feel free to merge!
... if you have permissions, that is. Otherwise I can take care of it.
I'm also satisfied with it. After my most recent active PR gets merged, I'm considering creating a new PR to address the latest version of MOAB. It appears that I inadvertently created a forked repo from another fork last time.
Description
First round of incremental documentation improvements in Spring 2023.
Motivation and Context
Documentation has become confusingly out of date and needs to be improved.
This round focuses on the home page and installation info.