Closed gonuke closed 1 year ago
This may ultimately simplify #863 for @shimwell as well?
Updated docker image builds available here: https://github.com/gonuke/DAGMC/actions/runs/4439152727
Looks like the docker builds failed with the python -c "import pymoab"
command.
Yes - I think that's a known failure of MOAB master
🤷
Actually, that looks like a long standing issue in our docker building... we try to build 5.4.0 in our docker images, but try build the subsequent steps with 5.3.0.
New docker image build: https://github.com/gonuke/DAGMC/actions/runs/4443513280
It doesn't make sense to build CI images with MOAB master
because (a) it changes regularly and the point is to test against the newest master
, and (b) that's why we clone & build MOAB master
manually for those cases. I removed that in 667710b
New docker CI image build: https://github.com/gonuke/DAGMC/actions/runs/4451584603
Had the wrong python version in the PYTHONPATH - new CI images building here: https://github.com/gonuke/DAGMC/actions/runs/4456756466
I took out the test of the pymoab install since it isn't needed for DAGMC testing - new image builds here: https://github.com/gonuke/DAGMC/actions/runs/4457395067
Everything appears to have built and all tests passed
Is it worth testing with Moab 5.4.0 in the matrix. I think it was taken out during this PR but it might be more important that 5.3.0
I can try 5.4.0, but I wouldn’t want it to hold this up.
Ok let us not try 5.4.0 then. I think this PR is good to merge. Shall we wait a little in case anyone else has comments
thanks for the improvements paul
Description
Change tests against MOAB
master
anddevelop
to be optional.Motivation and Context
We current only test on MOAB 5.3.0 during review of a PR, but then test on MOAB
master
anddevelop
upon merge. Those tests againstmaster
&develop
are meant to be advisory and not indicative of the state of the project.Changes
Change github action behavior.