More stable package find instructions

ebknudsen commented 1 year ago

Please follow these guidelines when making a Pull Request. This template was adapted from here and here.

Description

Stabililize the search routines for MOAB and double-down

Motivation and Context

double-down installs its .cmake-files explicitly to a subdirectory dd. This PR adds that subdir to the search path explicitly. In cases cmake does not find them otherwise
The MOAB search directory variable should be quoted. In some cases it can cause FindMOAB to fail. If it is installed to non-standard directory.

Changes

Bug-fix

Behavior

Old behaviour: can cause installation to fail. New behaviour: more stable installation, less dependent on local cmake parameters.

gonuke commented 1 year ago

Thanks @ebknudsen - this seems reasonable to me. I suppose we should be testing with DD at some point in our process - perhaps at merge time, even if not during PR review. Thoughts @pshriwise ?

pshriwise commented 1 year ago

Yes, I agree. I thought we were at some point. Did that go away?

svalinn / DAGMC