search

svalinn / DAGMC

Direct Accelerated Geometry Monte Carlo Toolkit
https://svalinn.github.io/DAGMC
Other
96 stars 63 forks source link

add limitation to cython version for MOAB compatibility & more selectivity about when some tests are run #893

Closed gonuke closed 1 year ago

gonuke commented 1 year ago

Description

Force cython version to be less than v3.0.0. At the same, be slightly more selective with triggers for some tests.

Motivation and Context

The versions of MOAB compatible with DAGMC are not compatible with cython 3+. pip installing cython recently changed to be v3, so we need to restrict the version.

Also, we are currently running tests on all platforms even when only changing the workflow on another platform.

Changes

bug fix for building dependencies

Limit when tests are run based on file paths.

gonuke commented 1 year ago

Test of docker image building are here.

gonuke commented 1 year ago

This is separated out from #880 to separate docker building steps from testing steps

gonuke commented 1 year ago

This built successfully on my fork, and should be ready for review & merge.

The last merge to develop here failed to update the docker images correctly so I'll be on the lookout for that this time.