search

svalinn / DAGMC

Direct Accelerated Geometry Monte Carlo Toolkit
https://svalinn.github.io/DAGMC
Other
96 stars 61 forks source link

Cleanup docker deploy #894

Closed gonuke closed 11 months ago

gonuke commented 11 months ago

Description

Remove dependence on unstable image tag for retagging.

Motivation and Context

Recent merges of our new docker image deployment have failed at the last step because we rely on a tag generated by the multi-stage-build-action that is automatically generated. The documentation for that project recommends that we do NOT rely on that tag. We could probably figure out something that would work, but it may be fragile based on the guidance from the authors of that action.

Changes

This uses logic tests to determine whether or not the images should be tagged as latest and only does so when it is a push to develop on the upstream svalinn repository. Pushes to other branches will still run the tests, building the full set of docker images, but will not tag them as latest.

gonuke commented 11 months ago

Build testing including successful pushes here.

gonuke commented 11 months ago

✅ Docker builds are successful and other build/test is irrelevant (?) because it's still using old docker images.

Hopefully, merging this will allow us to move forward with proper build/test on linux using the correct docker images... but we'll need to review the final step carefully since it only happens on push to svalinn/develop

shimwell commented 11 months ago

Just the sort of thing we needed.