svalinn / DAGMC

Direct Accelerated Geometry Monte Carlo Toolkit
https://svalinn.github.io/DAGMC
Other
96 stars 61 forks source link

Fix docker args #896

Closed gonuke closed 11 months ago

gonuke commented 11 months ago

Description

Pass correctly named docker arguments to manage builds.

Also streamlines the docker build & test further taking more advantage of the multi-stage-build action.

Motivation and Context

We currently build multiple docker images with a matrix of options. The variable names to control the HDF5 and MOAB versions were not named correctly. This did not create a flaw in our building/testing, because we only attempted a single version of each and those versions were the defaults anyway. This PR corrects that.

Changes

Rename the build args passed to Docker & combine two steps in the workflow.

gonuke commented 11 months ago

Success of this build is demonstrated here.

gonuke commented 11 months ago

New test of the docker building underway here.

gonuke commented 11 months ago

New test of the docker building underway here.

It appears to have been successful!