search

svalinn / DAGMC

Direct Accelerated Geometry Monte Carlo Toolkit
https://svalinn.github.io/DAGMC
Other
96 stars 61 forks source link

Add dd on merge #898

Closed gonuke closed 11 months ago

gonuke commented 11 months ago

Description

Add a test with Double Down on merge.

Motivation and Context

We discovered after a recent PR was merged that it broke compatibility with Double Down. For the time being, we have decided to only test that compatibility at merge and not with each PR.

Changes

Adds a matrix option to build DAGMC using Double Down. Also allows jobs to continue on error so that all options are tested even if one fails, since this is advisory post merge.

Also took the opportunity to collapse the docker builds in this workflow, and to exclude changes to this file from triggering other build/test actions.

Fixes #897

gonuke commented 11 months ago

A successful demonstration of this test is here, including the currently failing Double Down test.

gonuke commented 11 months ago

This looks good to me @gonuke. Thanks for including DD in the test suite! I'm assuming that the removed block for tagging and uploading Docker images is taken care of elsewhere as a result of previous PRs.

It's not clear whether we want to tag/push these docker images since their purpose was just to test against upstream dependencies.

pshriwise commented 11 months ago

Makes sense. Thanks for clarifying!