svalinn / DAGMC

Direct Accelerated Geometry Monte Carlo Toolkit
https://svalinn.github.io/DAGMC
Other
99 stars 63 forks source link

Add tests on merge for various upstream packages #899

Closed gonuke closed 1 year ago

gonuke commented 1 year ago

Description

Create a set of separate tests that are run when a PR is merged to identify problems with upstream packages.

Motivation and Context

We rely on a number of upstream dependencies and currently pin their version to ensure success on our builds. It is useful, however, to monitor whether or not we break compatibility with an upstream or optional package due to changes in our code base or their code base.

Changes

Adds three new tests that only occur on merge. Badges for these tests are at the bottom of the readme for a quick assessment.

Because we are adding the ability to test multiple versions of Geant, this changes to embed the Geant version in the image name.

gonuke commented 1 year ago

Evidence of docker images being built correctly here.

gonuke commented 1 year ago

When merged, the following should be true:

gonuke commented 1 year ago

Once merged, we'll need to update the linux build tests for the new image names, in a separate PR.

gonuke commented 1 year ago

Any chance that @shimwell or @pshriwise can give this a quick look over before tomorrow's call?

shimwell commented 1 year ago

Just reading up on composite actions which are new to me but I have managed to looked over this in time for the call