search

svalinn / DAGMC

Direct Accelerated Geometry Monte Carlo Toolkit
https://svalinn.github.io/DAGMC
Other
96 stars 61 forks source link

Fix order of attribute initialization #903

Closed pshriwise closed 11 months ago

pshriwise commented 11 months ago

Description

This fixes the issue referenced in #902 and is shown in this CI build failure for that PR.

Motivation and Context

Enables builds of DAGMC with MOOSE apps without failure.

Changes

Small refactor of the metadata class.

pshriwise commented 11 months ago

Any thoughts on this @gonuke, @shimwell?

https://github.com/svalinn/DAGMC/actions/runs/6039003224/job/16386661208

image

gonuke commented 11 months ago

This is currently expected to fail.

gonuke commented 11 months ago

This test should no longer be run on PRs after my most recent PR (if you rebase?)

pshriwise commented 11 months ago

This is currently expected to fail.

I'd expect #902 to fail due to the additional flags used in CI, but this PR reorders the class attribute initialization so I'd expect it to pass. Am I missing something?

gonuke commented 11 months ago

This failing action is to test against new versions of Geant. I don't see it in your checks for this PR.

pshriwise commented 11 months ago

Oh "this" being the CI build, not the PR itself. Though in the end I suppose the outcome is the same...

All looks well on this PR though 👍🏻 Sorry for the cross-talk.