search

svalinn / DAGMC

Direct Accelerated Geometry Monte Carlo Toolkit
https://svalinn.github.io/DAGMC
Other
96 stars 61 forks source link

Geant4 v11 fix #907

Closed ahnaf-tahmid-chowdhury closed 7 months ago

ahnaf-tahmid-chowdhury commented 10 months ago

I created a backup branch and reverted all the changes on my develop branch in the DAGMC repository. It seems like my previous PR got deleted in the process. Thus, I have created a new one. I apologize for any inconvenience this may have caused.

ahnaf-tahmid-chowdhury commented 10 months ago

Geant4 provide Geant4Config.cmake that allows to find Geant4. Do we still need FindGeant4?

ahnaf-tahmid-chowdhury commented 10 months ago

Adding #860 for history

ahnaf-tahmid-chowdhury commented 10 months ago 
#34 5.300 /root/build_dir/dagmc/src/pyne/pyne.cpp/root/build_dir/dagmc/src/dagmc/DagMC.cpp:816:18: error: out-of-line definition of 'find_volume' does not match any declaration in 'moab::DagMC'
  #34 5.305 ErrorCode DagMC::find_volume(const double xyz[3], EntityHandle& volume,
  #34 5.306                  ^~~~~~~~~~~
  #34 5.308 :12283:74: warning: implicit conversion from 'const Json::Int64' (aka 'const long long') to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Wimplicit-int-float-conversion]
ahnaf-tahmid-chowdhury commented 8 months ago

@gonuke docker build is passing now