search

svalinn / DAGMC

Direct Accelerated Geometry Monte Carlo Toolkit
https://svalinn.github.io/DAGMC
Other
99 stars 63 forks source link

Geant4 v11 update #924

Closed gonuke closed 10 months ago

gonuke commented 10 months ago

Note: These changes were first proposed in #907 by @ahnaf-tahmid-chowdhury. In order for the docker build process to test smoothly, a new PR is being issued with all those changes, attributed to him, but without updating the standard linux_build_test.yml workflow. That workflow will require the new docker images to exist first.

Description

Introduce changes to support building against Geant4 v11.x

Motivation and Context

Some code API changes for Geant4 require some changes.

Changes

Supports build of newer versions of Geant4

Expected behavior

Since these changes should be backward compatible with v10 of Geant4, all tests should pass including testing on both new and old versions of Geant4

gonuke commented 10 months ago

Mac testing will fail until we merge #922

ahnaf-tahmid-chowdhury commented 10 months ago

I think, there is no need to install gcc manually. GitHub workflow already comes with built-in dev tools.

gonuke commented 10 months ago

I'm trying to skip gcc in #922 right now

gonuke commented 10 months ago

I think, there is no need to install gcc manually. GitHub workflow already comes with built-in dev tools.

Thanks @ahnaf-tahmid-chowdhury - I've moved that change into this PR since it was such a small change.

Looking for a review here from @pshriwise @shimwell @makeclean @helen-brooks ?

gonuke commented 10 months ago

Thanks for the review @pshriwise - I think I addressed everything.