search

svalinn / DAGMC

Direct Accelerated Geometry Monte Carlo Toolkit
https://svalinn.github.io/DAGMC
Other
96 stars 61 forks source link

Add action to test newer hdf5 version #925

Closed bquan0 closed 7 months ago

bquan0 commented 7 months ago

Description

I made a copy of one of the linux_upstream_test.yml files and modified it slightly to use the composite action with an argument of hdf5_version: 1.14 as specified in #916. I'm guessing this is what the issue is asking me to do? I'm not entirely sure because it wasn't specific. The issue also mentions that there are interactions between dependencies, which can be easily added with a matrix in the linux_upstream_test_hdf5.yml file. However, I don't know what interactions need to be tested, so I didn't add the matrix just yet.

Behavior

New behavior is that there will be one more action run when PRs are merged to develop that will test whether DAGMC works with version 1.14 of hdf5.

gonuke commented 7 months ago

Are you able to manually launch this action on your fork?

Also, please look at the bottom of the README to add a badge for this, as well.

bquan0 commented 7 months ago

Looks like the workflow for hdf5_version: 1.14.0 worked. I've just edited it to be 1.14.3, so we'll see if that works too. I also mapped the hdf5 workflow badge to my repo and branch just to see if it would work. That's something I'll have to change before this PR gets merged.

gonuke commented 7 months ago

Thanks @bquan0 - I think this looks OK - go ahead and switch back the README and I'll merge.