search

svalinn / DAGMC

Direct Accelerated Geometry Monte Carlo Toolkit
https://svalinn.github.io/DAGMC
Other
96 stars 61 forks source link

add 1.11.2 geant4 to routine build testing #927

Closed gonuke closed 7 months ago

gonuke commented 7 months ago

Add routine testing against Geant4 1.11.2 now that the docker images support it.

I promise this is the last step in getting the Geant4 update done.

ahnaf-tahmid-chowdhury commented 7 months ago

We are getting DD fail after last merge!

ahnaf-tahmid-chowdhury commented 7 months ago

Oops! Sorry. DD is failing every time. I may create a PR. It might be due to some configuration error.

gonuke commented 7 months ago

It's a known issue that DD fails and it fails in an advisory way. @pshriwise is working on a release of DD to fix this

gonuke commented 7 months ago

Sorry to nag @shimwell or @pshriwise but this really is the end before a release and hopefully more regular releases and conda-forge updates and working towards a pip installable... etc

shimwell commented 7 months ago

This looks straightforward to me. Adding another version to the matrix. All the Ci checks passed. Doesn't look like there is much to review here unless I'm missing something

gonuke commented 7 months ago

You can go ahead and merge @shimwell