search

svalinn / DAGMC

Direct Accelerated Geometry Monte Carlo Toolkit
https://svalinn.github.io/DAGMC
Other
96 stars 61 forks source link

Remove eigen3 #941

Closed ahnaf-tahmid-chowdhury closed 5 months ago

ahnaf-tahmid-chowdhury commented 5 months ago

This PR removes Eigen3 from DAGMC dependency.

ahnaf-tahmid-chowdhury commented 5 months ago

What!!! I have turned off BLASLAPACK, but it seems the CMake is still considering it enabled!

ahnaf-tahmid-chowdhury commented 5 months ago

I see, we need to enable blaslapack and need to find lapack, which will enable Fortran support. In that way we can ignore Eigen3 support for MOAB 😕. @gonuke, do you like to proceed with blaslapack?

More info: here

gonuke commented 5 months ago

We definitely want Eigen3 and not BLAS and LAPACK.

gonuke commented 5 months ago

I'm not sure what problem this is trying to solve?

ahnaf-tahmid-chowdhury commented 5 months ago

This one #799

gonuke commented 5 months ago

This one #799

I thought that might be it. This is a different problem. The problem is not that Eigen3 is a dependency of DAGMC. The problem is that Eigen3 is included in header files of MOAB and DAGMC that are required by downstream apps, even when it may not be necessary. The solution to this requires a little more careful analysis of each header file that included Eigen3 headers, moving the Eigen3 include to the source file, and seeing whether some forward declarations are necessary where the Eigen3 has been removed from headers.

ahnaf-tahmid-chowdhury commented 5 months ago

Thank you for highlighting the issue with Eigen3 inclusion in header files.