search

svalinn / DAGMC

Direct Accelerated Geometry Monte Carlo Toolkit
https://svalinn.github.io/DAGMC
Other
96 stars 61 forks source link

Simplify Housekeeping Process for DAGMC #943

Closed ahnaf-tahmid-chowdhury closed 5 months ago

ahnaf-tahmid-chowdhury commented 5 months ago

Description

This PR simplifies the housekeeping process for DAGMC by removing the dependency on a Docker container and installing clang-format directly through the workflow.

Related Issues

Housekeeping of DAGMC is very complicated now. And it seems in the docker file, we are just installing clang-format through apt. Also, I noticed the docker publish file is changed and there is no way to rebuild a new docker image for housekeeping.

Changes

gonuke commented 5 months ago

perhaps we should update these two files to match what clang-format is generating as part of this PR so that it passes tests

gonuke commented 5 months ago

This now has a conflict in the CHANGELOG.rst

gonuke commented 5 months ago

It looks like there is an update in CMake version in the new Windows runner... I'm not sure yet if/why that is causing a problem.

gonuke commented 5 months ago

We may need to provide more information to our CMake config for MOAB. It may be true that MOAB should improve their custom FindEigen macro, but providing EIGEN3_DIR may be easier