search

svalinn / DAGMC

Direct Accelerated Geometry Monte Carlo Toolkit
https://svalinn.github.io/DAGMC
Other
100 stars 63 forks source link

Windows CI is failing #957

Closed gonuke closed 3 months ago

gonuke commented 3 months ago

Describe the Bug
Windows CI is suddenly failing. It may be due to outdated versions of some GH actions due to updates in the Windows runner

gonuke commented 3 months ago

It looks like updating actions is not enough 😟

The primary symptom is that it fails to find the pyne.cpp. I don't know the root cause, but it could be related to:

pshriwise commented 3 months ago

I poked around a bit in a tmate session. It appears that the GHA Windows runner cannot find the version of bash we're prescribing here:

https://github.com/svalinn/DAGMC/blob/7e1cdb638b59ba22fd6ff0b09e94d8f658a1eadf/src/pyne/CMakeLists.txt#L4-L7

Inside the tmate session, changing that hardcoded path to the bash.EXE to bash resulted in a successful CMake configuration. I'm not 100% sure this will work for all cases, but I think Windows native support for shell has become good enough that it's safe to rely on this.

pshriwise commented 3 months ago

Got a successful run with that tweak here: https://github.com/pshriwise/DAGMC/actions/runs/9994402642

Commit: https://github.com/pshriwise/DAGMC/commit/e4486acc16d414c138dbdf61fb35dd5bc95b77be