search

svalinn / dagmc_stats

Tool for calculating and reporting statistics about DAGMC models
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

Coarseness #55

Closed yqin43 closed 4 years ago

yqin43 commented 5 years ago

Description

Added function that calculates the coarseness of all the surfaces

Changes

In dagmc_stats.py: added function for coarseness calculation(get_coarseness) In generate_stats.py: added code to call the get_coarseness function

gonuke commented 4 years ago

I think this needs to be rebased against the recently merged PR.

gonuke commented 4 years ago

I think this needs to be rebased against the recently merged PR.

Looks like you just fixed this - ignore...

kkiesling commented 4 years ago

@yqin43 can you rebase against master to get your most recent PRs into this one? That may require you to resolve a conflict in the test file. Let me know if you need help resolving the conflict.

kkiesling commented 4 years ago

I think comments from @gonuke have been addressed, but I'll let him approve before I merge.

gonuke commented 4 years ago

LGTM - thanks for your work on this @yqin43