search

svalinn / dagmc_stats

Tool for calculating and reporting statistics about DAGMC models
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

Roughness #59

Closed yqin43 closed 4 years ago

yqin43 commented 4 years ago

Description

5 functions calculating roughness are added: (roughness is calculated based on part 3.2 Local Roughness of article "A fast roughness-based approach to the assessment of 3D mesh visual quality")

get_beta_angles: get the beta angles (See fig 3) get_angles: get angles of a triangle(the first element in the list "angles" is always the alpha angle)(See fig 3) gaussian_curvature: calculate gaussian curvature value of given vertex (See formula 1) get_local_roughness: calculate local roughness value of given vertex (See formula 2) get_roughness: return local roughness values for all the vertices (See formula 3)

Other Information

Reference: A fast roughness-based approach to the assessment of 3D mesh visual quality https://www.sciencedirect.com/science/article/pii/S0097849312001203

gonuke commented 4 years ago

Thanks for this complicated new addition! It looks like a lot of work and very valuable to @kkiesling's progress.

yqin43 commented 4 years ago

@gonuke @kkiesling Thank you for your suggestions and I have edited them except the ones corresponding to how to get the beta angles. I have also updated the test file.

I would like to talk about the beta angle problem during the software meeting as Kalin suggested. Currently it seems to be pretty complicated.

yqin43 commented 4 years ago

Code in dagmc_stats.py and test file has been edited according to PEP8 style and tests for new functions are added. Please check these changes. Thanks!

kkiesling commented 4 years ago

@yqin43 - can you change this PR so that you are requesting merging into the main branch rather than the master? You should be able to click the clipboard button at the top of the page to edit the branch.

kkiesling commented 4 years ago

never mind- I have permission to change the base branch so I updated it.

gonuke commented 4 years ago

Thanks for all the work on the complex new metric, @yqin43 !!!