search

svalinn / dagmc_stats

Tool for calculating and reporting statistics about DAGMC models
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

More CI/testing updates #61

Closed kkiesling closed 4 years ago

kkiesling commented 4 years ago

As I am learning more and more about CI, testing, and pytest, I realized there are updates needed here. This PR does the following:

  1. remove the pip install line from CI (unnecessary)
  2. Changes the paths of the .h5m test files to be relative to the top level directory so that pytest can be run from the top level
  3. runs pytest from the top level directory on CI
kkiesling commented 4 years ago

I think it is fine to remove pip install -e . --user. But I would suggest to install it using pip (with out the -e) and try to import it from the ROOT folder.

I don't quite understand what you are suggesting

bam241 commented 4 years ago

basically having a job checking the proper installation of the package, and that you can import it

bam241 commented 4 years ago

LGTM! thx @kkiesling

Merging on test completion