search

svalinn / dagmc_stats

Tool for calculating and reporting statistics about DAGMC models
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

Returns EntitySet Ranges #8

Closed epickhardt closed 5 years ago

epickhardt commented 5 years ago

Added comments to wrap up the function

gonuke commented 5 years ago

I think this is a good narrow-scope PR to focus on getting done to practice the process of updating and reviewing PRs. A PR is like a writing assignment that ends up with a few rounds of editing and review, whether by you or others.

You may want to review PEP8 that we use for our style guide: feedback on style can appear pedantic/tedious at first (and maybe forever), but is an important component of long term code maintenance. There are tools to help accomplish PEP8 compliance. Note: my initial commit may not have been compliant!

Even in its current form, the changes you made deserve some changes to the tests. This is something we can discuss because that might not be obvious. If/when you make a separate function, you’ll want to write new test(s) for that function.