search

svalinn / dagmc_stats

Tool for calculating and reporting statistics about DAGMC models
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

Coarseness and Roughness #88

Closed yqin43 closed 2 years ago

yqin43 commented 2 years ago

Description

Added calc_coarseness and calc_roughness functions and their corresponding tests.

gonuke commented 2 years ago

In the future, it would be great to have pure PEP8 updates for existing code in a different PR. It is easier to review a large set of formatting changes separately from some algorithmic changes because of the cognitive burden of deciding whether something is just a formatting change or a substantive change.

kkiesling commented 2 years ago

In the future, it would be great to have pure PEP8 updates for existing code in a different PR. It is easier to review a large set of formatting changes separately from some algorithmic changes because of the cognitive burden of deciding whether something is just a formatting change or a substantive change.

ya that is my bad. Those all came from me.

kkiesling commented 2 years ago

Just FYI @gonuke - we just discovered that the pyramid geometry file we have been using in testing doesn't have CATEGORY tags. Not sure why because I made it in Trelis a while ago w/ the DAGMC plugin. I'll need to regenerate that but for now it is not working as we expect with the tests (and therefore they will likely fail). I am confident this is an issue with the geom file, not the code.

gonuke commented 2 years ago

@kkiesling - you have an outstanding review here. To be consistent with our practices, I want to give you a chance to review this again, or otherwise remove your review. I'm ready to merge

gonuke commented 2 years ago

Thanks @yqin43