Rewrite CMake for robustness as both standalone library and part of Trelis plugin

svalinn / mcnp2cad

Convert MCNP input files to a general CAD format

BSD 2-Clause "Simplified" License

34 stars 31 forks source link

Rewrite CMake for robustness as both standalone library and part of Trelis plugin #68

Closed ljacobson64 closed 4 years ago

ljacobson64 commented 4 years ago

This is a companion PR to https://github.com/svalinn/Trelis-plugin/pull/56.

ljacobson64 commented 4 years ago

I just realized that I made this branch in in the svalinn repo instead of my own fork... didn't intend to do that. I don't think it can be changed though.

ljacobson64 commented 4 years ago

I just confirmed that it is possible to build mcnp2cad as a standalone library (along with the CLI executable) on top of CGM which is built on top of OpenCascade. No guarantees that it works though.

ljacobson64 commented 4 years ago

I just realized that the mcnp2cad readme now contains wrong information. I could take some time to update it, or we could just leave it and update it later.

pshriwise commented 4 years ago

I'm fine w/ making that a separate PR right after this one.

pshriwise commented 4 years ago

@gonuke when you have time can you take another look? I think we're close to getting these Trelis-Plugin/mcnp2cad issues resolved.

gonuke commented 4 years ago

I left a couple of final comments. The most pressing one is about ensuring we can find Eigen