search

svalinn / mcnp2cad

Convert MCNP input files to a general CAD format
BSD 2-Clause "Simplified" License
34 stars 31 forks source link

Mac build #73

Closed bam241 closed 3 years ago

bam241 commented 3 years ago

this allow to build.on Mac OS

it also an autogenerated version.hpp file for the version numbers.

bam241 commented 3 years ago

when compiling on Mac OS with non-standalone mode I got:

Undefined symbols for architecture x86_64:
"_Gopt", referenced from: [...]

which is solved by defining struct program_option_struct Gopt; which is defined original in option.hpp as extern.

bam241 commented 3 years ago

@gonuke @pshriwise @ljacobson64 this should be ready to be reviewed.

bam241 commented 3 years ago

@gonuke I think I addressed all your comments.

(@pshriwise @gonuke this is the next PR to get reviewed/merged in the Trellis-plugin GitHub Action chain.)

gonuke commented 3 years ago

In the absence of CI, I'll merge this for testing downstream