search

svalinn / mcnp2cad

Convert MCNP input files to a general CAD format
BSD 2-Clause "Simplified" License
34 stars 31 forks source link

Windows build #74

Closed bam241 closed 3 years ago

bam241 commented 3 years ago

small change required to find Eigen3 on windows.

this goes on top of #73

gonuke commented 3 years ago

How do we find Eigen3 for MOAB on windows? Does MOAB have it's own FindEigen as well?

bam241 commented 3 years ago

I stole that one from MOAB.

Maybe there is a way to get the EIGEN path form libMOAB but didn't know how to do so...

gonuke commented 3 years ago

I stole that one from MOAB.

Maybe there is a way to get the EIGEN path form libMOAB but didn't know how to do so...

No - that's fine. I just wasn't sure if MOAB had their own or not - we can include one here.

bam241 commented 3 years ago

@pshriwise @gonuke I think this should be ready

gonuke commented 3 years ago

Can we setup CI for this?? (incl. Windows) I know we've discussed before. It is hard to do tests since the output is a geometry file, but we could at least confirm that it builds and runs?

bam241 commented 3 years ago

@gonuke do you still want CI to be part of this ?

or shall we take care of this in the thx PR ?

gonuke commented 3 years ago

I think for now, we can rely on the plugin CI to test this, since it's the only place we use it. Maybe at our next meeting we can discuss how to incorporate some kind of CI. For example, we could build the plugin as part of this repo's CI a a test??

gonuke commented 3 years ago

BTW, it should be possible to get the Eigen3 path from MOAB, but let's make an issue out of that and move this forward.

gonuke commented 3 years ago

Thanks for helping get us up and running on Windows @bam241