check_watertight needs default value of tolerance to check model for water tightness

svalinn / moab_tools

Tools for manipulating and examining moab meshes

2 stars 4 forks source link

check_watertight needs default value of tolerance to check model for water tightness #5

Open makeclean opened 11 years ago

makeclean commented 11 years ago

check_watertight, currently when no tolerance is provided defaults to zero, there should be either

a default value of tolerance to check against
determined by the h5m file input

pshriwise commented 11 years ago

Wouldn't we just use the faceting tolerance as taken from the .h5m file. Or perhaps an order larger? (10xfacet_tol?)

makeclean commented 11 years ago

Yes, or possibly down to dags facet intersection tolerance 1.e-6

pshriwise commented 11 years ago

I would be ok with that. I'd like it working as robustly as possible.

pshriwise commented 10 years ago

Issue handled. There are two ways in which check_watertight works. One in which is uses the proximity facet vertices to ensure that they are within some tolerance of each other (the tolerance being specified by the user after the -f flag in the command), and the other is a topological check, making sure that each vertex handle on one surface skin has a matching vertex handle on the corresponding skin of an adjacent surface.

makeclean commented 10 years ago

Ok, is this reflected in the documention?

pshriwise commented 10 years ago

Not yet. I'll add it into the doxygen documentation for check_mesh_for_watertightness.