svalinn / parastell

Parametric 3-D CAD modeling toolset for stellarator fusion devices
MIT License
26 stars 12 forks source link

change default value to match docstring in ivb #119

Closed Edgar-21 closed 4 months ago

Edgar-21 commented 4 months ago

fixes #118

@connoramoreno I just guessed that this should be updated to match the docstring rather than the other way around, lmk if that is not the case

connoramoreno commented 4 months ago

Let's keep the default value at 67 and just update the docstring. Good catch!

Edgar-21 commented 4 months ago

black autoformatting got to one of these files hence the big diff

Edgar-21 commented 4 months ago

CI seems to be failing on test_magnet_coils.py for some reason? I didn't touch anything to do with that in this pr, and tests are passing locally for me

Edgar-21 commented 4 months ago

nevermind its because this is on my fork, I'll have to reopen a different pr doing the same thing