search

svalinn / parastell

Parametric 3-D CAD modeling toolset for stellarator fusion devices
MIT License
27 stars 12 forks source link

Using wall_s=1.0 and a custom SOL definition with split_chamber=False does not merge the plasma and SOL #144

Closed Edgar-21 closed 2 months ago

Edgar-21 commented 2 months ago

Expected behavior is to get one volume representing the SOL combined with the plasma.

connoramoreno commented 2 months ago

Edgar and I resolved this, but for future reference, to have the "chamber" volume be offset from the plasma by a given thickness matrix when split_chamber = False, include an item in the radial build with the key "chamber" and desired "thickness_matrix" value. Including a radial build item with a "sol" key will create a separate "sol" component. We can consider adding a warning about this.