search

svalinn / parastell

Parametric 3-D CAD modeling toolset for stellarator fusion devices
MIT License
24 stars 11 forks source link

Prevent pushes from modifying svalinn's parastell docker image #154

Closed bquan0 closed 1 week ago

bquan0 commented 2 weeks ago

Previously, the location to which the docker image was being pushed was hardcoded to the svalinn user. I have changed all instances of svalinn in docker_publish.yml to ${{ github.repository_owner }} so that the docker images being built on forks will be pushed to the user's fork, and will not overwrite svalinn's docker image.

This will allow contributors to test changes without worrying about the changes breaking svalinn's docker image. Also, once a contributor's PR is merged, docker_publish.yml will run on the svalinn user's repo and it will update the svalinn user's docker image.

To see this working, see this parastell-ci image that I now have as part of my packages.

bquan0 commented 2 weeks ago

Following Connor's clarification about how testing the image doesn't work on forked repos due to secrets, I reverted my changes and added code to tag images with the branch name if the branch isn't main. However, the test failed because it couldn't push the image. The correct tag is applied though.

gonuke commented 1 week ago

I've added you as a collaborator on this repo - can you try resubmitting this from a local branch for more robust testing?

bquan0 commented 1 week ago

Closing this PR because I made a new PR that's based on a branch in the svalinn repo instead of a branch in my forked repo.