Fix MOAB canonical ordering during element splitting

svalinn / parastell

Parametric 3-D CAD modeling toolset for stellarator fusion devices

MIT License

26 stars 12 forks source link

Fix MOAB canonical ordering during element splitting #167

Closed connoramoreno closed 1 month ago

connoramoreno commented 1 month ago

Corrects implementation of MOAB canonical ordering. Changes are as follows:

Changes MOAB canonical ordering for both wedges and hexahedra to coincide with element splitting shown in ParaStell publication (Moreno, Bader, Wilson, 2024)
Adds documentation explaining MOAB canonical ordering for posterity

Closes #166

gonuke commented 1 month ago

Should we have a test for this somehow?

connoramoreno commented 1 month ago

I'm not sure how we'd test canonical ordering of tetrahedra/splitting of elements directly but one test that we should probably add is to ensure no elements with negative volume are present