search

svalinn / r2s-act

Rigorous 2 Step Activation Workflow
4 stars 7 forks source link

Incorrect logic in particle identifier for wwinp_to_h5m.py #60

Closed bohmt closed 11 years ago

bohmt commented 11 years ago

The code that attempts to identify the particle type/s in the MCNP wwinp file is incorrect. The wwinp file may contain weight windows for neutrons, photons, or both. In the wwinp file, the second line listed in the file may contain 1 or 2 entries and has the format: "number of neutron energy groups" "number of photon energy groups" If there are no photon groups, then there is only one entry. If there are no neutron groups, then a "0" is listed in the first position. I have attached a sample wwinp file with labels that show an example with 7 neutron energy groups and 7 photon energy groups. ooex41screen

elliottbiondo commented 11 years ago

To be clear, the code works fine when a single WWINP contains only neutron or photon weight windows, but having both in one file is a feature that can/should be supported.

Just a quick note: the file you are using as an example contains cylindrical weight widows which are not supported.

makeclean commented 11 years ago

@biondo i believe you fixed this?

elliottbiondo commented 11 years ago

Yes, the read/write methods of the PyNE Wwinp class fully support simultaneous neutron and photon weight windows.

Since these capabilities are general enough to live outside R2S-ACT I do think it is necessary to reimplement them within R2S-ACT, in which case I will close this issue.