To address io naming problem

svalinn / r2s-act

Rigorous 2 Step Activation Workflow

4 stars 7 forks source link

To address io naming problem #67

Closed makeclean closed 10 years ago

makeclean commented 10 years ago

There is an issue with R2S-ACT that using the directory name 'io' to address modules is poor practice since 'io' is a reserved name in Python, it was leading to clashes with other python scripts. I have renamed the 'io' directory to data_transfer and updated python 'from ... use ...' accordingly. I would appreciate if @elliottbiondo could test.

erelson commented 10 years ago

Tried running tests for this; looks like you forgot to update the imports in a few of the test scripts :)

erelson commented 10 years ago

Also thanks! This started biting me today shortly after I just happened to decide to try your fixed branch. Would have had no clue what was going on if I hadn't looked at this...

I would hazard to guess that making an actual installable python package would avoid issues as well.

elliottbiondo commented 10 years ago

I think I got the rest of them. The tests that are in there pass. Perhaps someone else could double check.