search

svalouch / rctmon

Pulls data from RCT Power GmbH devices for use with monitoring systems.
https://rctmon.readthedocs.io
GNU General Public License v3.0
17 stars 8 forks source link

docker container #14

Open poggenpower opened 2 years ago

poggenpower commented 2 years ago

Hi,

I am working on a docker container running this project. Before publishing this in a 2nd place I would like to ask if you are open to PRs around this topic. Could be useful for others to have all the things in one place.

If not this is also OK and I will create a separate project.

Bye Thomas

sfudeus commented 2 years ago

There might already be more but I did a trivial packaging of rctmon into a (multiarch) container image myself: https://github.com/sfudeus/docker_rctmon, to be found at docker.io/sfudeus/rctmon Even better if we could get this into the original source :-)

svalouch commented 2 years ago

I'm not using docker myself and thus can't provide support for it, though I'd be fine with including an example Dockerfile somewhere. My preferred solution would be to add links to images to the documentation, e.g. to @sfudeus's.

poggenpower commented 2 years ago

The problem with providing a docker image instead.of a docker file is that it need to be maintained. Not only if there are updates from rctmin, but also security patches of the base image and python. A lot of this can be automated with git actions, but requires some additional efforts. Long story short if linking to an image it should be one that is maintained.

Regarding some deployment docs, I can also provide an example for a kubernetes deployment.

sfudeus commented 2 years ago

Besides linking my image in Docker-Hub feel free to link my Github-Repo (https://github.com/sfudeus/docker_rctmon) for it as well, which of course contains a Dockerfile. Feel free to copy my Dockerfile here as well. My Docker image is auto-built once a week to ensure updated an updated base image.

sfudeus commented 2 years ago

Sidenote: Currently my docker image is already pointing to a PR-branch I did for rctmon, but in general this is supposed to point to master/main. I'll update the setup to be able to build these in addition to master.