search

svalouch / rctmon

Pulls data from RCT Power GmbH devices for use with monitoring systems.
https://rctmon.readthedocs.io
GNU General Public License v3.0
17 stars 9 forks source link

Switch powerswitch data to own metrics #25

Closed sfudeus closed 1 year ago

sfudeus commented 2 years ago

This fixes collision of voltage data between grid and powerstorage. Fixes #24. When looking into it, the easiest and most consistent way really was to just rename the prefix for the powerswitch metrics to rctmon_powerswitch. This decouples it from the collision in rctmon_grid_voltage and will not be visible for people not having a powerswitch, because rctmon_grid_frequency would not have been populated (per phase). The only change is for people with powerswitch, reading the frequency per phase, this name has changed to rctmon_powerswitch_frequency

MichaelMMS commented 2 years ago

Oh, I only saw your post now. Great! I hope svalouch will merge our changes soon;)

kaitimmer commented 2 years ago

What is missing to get this merged?

I'm trying to scrape the metrics with Telefraf, which can not really handle the duplicated names.

reading text format failed: text format parsing error in line 168: second HELP line for metric name "rctmon_grid_voltage_volt"

Would be good to know how we can get this fixed and seeing that this PR is open for quite a while it would be good to know how we can help.

MichaelMMS commented 1 year ago

He hasn't done anything on github since june. Maybe he doesn't have time for it anymore. Maybe someone should make a fork to bring this valuable project forward?

poggenpower commented 1 year ago

Instead of a fork @svalouch could give someone else permissions to merge into this repo. Then it all stays at the same place.