search

svandecappelle / jQPlot

JQplot revival
http://svandecappelle.github.io/jQPlot/
MIT License
29 stars 13 forks source link

revert the jslint merge commits erros #64

Open svandecappelle opened 8 years ago

svandecappelle commented 8 years ago

Lots of commits causes regressions on functionalities:

johanbove commented 8 years ago

What kind of issues are you experiencing? I made sure that all visible examples and tests still ran, so I'm really curious what kind of issues you found.

svandecappelle commented 8 years ago

The check intersection method is returned a first series loop. In fact all hover or check intersection events concerning the series index > 1 did not fired any events. See what I changed: https://github.com/svandecappelle/jQPlot/blob/83c9d184d9f2826551d0d027f57cddd487b29408/src/core/jqplot.core.js#L693

Function return was called after each 'case' statement. Wich caused the loop always break after first serie.

An exemple of the issue: donut chart -> Hover your mouse on a slice. There is no highlight color. The jqplot github pages are already patched with the new version.

johanbove commented 8 years ago

I'm sorry the "code cleanup" resulted in these issues. I thought it would be good to make the code more readable and following linting rules. Did you create a test for this issue?