search

svanderburg / node2nix

Generate Nix expressions to build NPM packages
MIT License
527 stars 100 forks source link

New release #274

Open mkg20001 opened 3 years ago

mkg20001 commented 3 years ago

Would it be possible to create a new release to include the latest fixes in nixpkgs or is there anything blocking that?

svanderburg commented 3 years ago

I'm close to it. The only thing that is "blocking" the release is my investigation of patching the bin/ executables after running npm rebuild. I'm still investigating what the impact of that would be and if it doesn't make things worse.

If you want to help, try to find packages that rely on rebuilding and see if the deployments still work acceptably.

mkg20001 commented 3 years ago

Usually packages that deliver bindings have the source code for whatever they're trying to build shipped with them and optionally fetch prebuilt assets at build time

Meaning if there's no internet connection - like during the drv build - the rebuild will fallback to building binaries regularly, meaning they will work out-of-the-box on nixOS

I never really had a case where that didn't work

svanderburg commented 3 years ago

I'm almost ready. Tomorrow I'll run some final checks, then publish a new release and then work on updating Nixpkgs.

svanderburg commented 2 years ago

I've now started on a PR to update Nixpkgs with newly generated expressions: https://github.com/NixOS/nixpkgs/pull/146440