search

svanderburg / node2nix

Generate Nix expressions to build NPM packages
MIT License
519 stars 99 forks source link

`node2nix --help` is not updated with `--nodejs-16` option #291

Open quinn-dougherty opened 2 years ago

quinn-dougherty commented 2 years ago

node2nix --help does not inform the user that 16 functionality is there.

svanderburg commented 2 years ago

Hmm really? I can clearly see, that for me it's there:

$ node2nix --help
...
  -16, --nodejs-16              Provides all settings to generate expression for usage with Node.js 16.x (default is: Node.js 12.x)
CMCDragonkai commented 2 years ago

Hey might be referring to the node2nix that is in nixpkgs master. On revision https://github.com/NixOS/nixpkgs/commit/a5774e76bb8c3145eac524be62375c937143b80c node2nix is still 1.9.0 even though it claims to be 1.10.0.

nix-repl> pkgs.nodePackages.node2nix.version
"1.10.0"

nix-repl> node2nix
«derivation /nix/store/ipkkiavdmj2m8m9zxdkjsd8kfxqdj27c-node2nix-1.10.0.drv»

nix-repl> :b node2nix
[62 copied (334.6 MiB), 79.6 MiB DL]

this derivation produced the following outputs:
  out -> /nix/store/nz0fw6vhdfhv45nzlxahp6383p3m9lyj-node2nix-1.10.0

But:

$ /nix/store/nz0fw6vhdfhv45nzlxahp6383p3m9lyj-node2nix-1.10/bin/node2nix --version
node2nix 1.9.0
$ /nix/store/nz0fw6vhdfhv45nzlxahp6383p3m9lyj-node2nix-1.10/bin/node2nix --help | grep nodejs
  -4, --nodejs-4                Provides all settings to generate expression for usage with Node.js 4.x (default is: Node.js 12.x)
  -6, --nodejs-6                Provides all settings to generate expression for usage with Node.js 6.x (default is: Node.js 12.x)
  -8, --nodejs-8                Provides all settings to generate expression for usage with Node.js 8.x (default is: Node.js 12.x)
  -10, --nodejs-10              Provides all settings to generate expression for usage with Node.js 10.x (default is: Node.js 12.x)
  -12, --nodejs-12              Provides all settings to generate expression for usage with Node.js 12.x (default is: Node.js 12.x)
  -13, --nodejs-13              Provides all settings to generate expression for usage with Node.js 13.x (default is: Node.js 12.x)
  -14, --nodejs-14              Provides all settings to generate expression for usage with Node.js 14.x (default is: Node.js 12.x)
  --pkg-name NAME               Specifies the name of the Node.js package to use from Nixpkgs (defaults to: nodejs)

It doesn't even show the --nodejs-16 option.

andersk commented 2 years ago

nixpkgs.node2nix was upgraded in NixOS/nixpkgs#171195. I think this issue can be closed. Node 16 still doesn’t work, but we have other issues about that: #236, #293.