Bootstrapping is a lot faster on provisioning because steps are skipped when requirements are installed. A further iteration might want to update the tool if instead of installing it.
Fixes an issue where the default configuration file is missing out on a BASE_DIR check and checks for the legacy BASE_PATH instead: no more direct access denied errors.
This PR removes psalm, the version installed within the guest cannot deal with the themes/basic folder:
> psalm --alter --issues=all
Scanning files...
Uncaught UnexpectedValueException: File /vagrant/src/themes/basic/ is a directory in phar:///home/vagrant/.phive/phars/vimeo/psalm-3.16.0.phar/src/Psalm/Internal/Provider/FileProvider.php:34
Stack trace:
#0 phar:///home/vagrant/.phive/phars/vimeo/psalm-3.16.0.phar/src/Psalm/Internal/Codebase/Scanner.php(398): Psalm\Internal\Provider\FileProvider->getContents()
#1 phar:///home/vagrant/.phive/phars/vimeo/psalm-3.16.0.phar/src/Psalm/Internal/Codebase/Scanner.php(252): Psalm\Internal\Codebase\Scanner->scanFile()
#2 phar:///home/vagrant/.phive/phars/vimeo/psalm-3.16.0.phar/src/Psalm/Internal/Codebase/Scanner.php(321): Psalm\Internal\Codebase\Scanner->Psalm\Internal\Codebase\{closure}()
#3 phar:///home/vagrant/.phive/phars/vimeo/psalm-3.16.0.phar/src/Psalm/Internal/Codebase/Scanner.php(231): Psalm\Internal\Codebase\Scanner->scanFilePaths()
#4 phar:///home/vagrant/.phive/phars/vimeo/psalm-3.16.0.phar/src/Psalm/Codebase.php(346): Psalm\Internal\Codebase\Scanner->scanFiles()
#5 phar:///home/vagrant/.phive/phars/vimeo/psalm-3.16.0.phar/src/Psalm/Internal/Analyzer/ProjectAnalyzer.php(425): Psalm\Codebase->scanFiles()
#6 phar:///home/vagrant/.phive/phars/vimeo/psalm-3.16.0.phar/src/psalter.php(356): Psalm\Internal\Analyzer\ProjectAnalyzer->check()
#7 phar:///home/vagrant/.phive/phars/vimeo/psalm-3.16.0.phar/src/psalm.php(127): require_once('phar:///home/va...')
#8 phar:///home/vagrant/.phive/phars/vimeo/psalm-3.16.0.phar/psalm(5): require_once('phar:///home/va...')
#9 /home/vagrant/.phive/phars/vimeo/psalm-3.16.0.phar(14): require('phar:///home/va...')
#10 {main}
(Psalm 3.16@d03e5ef057d6adc656c0ff7e166c50b73b4f48f3 crashed due to an uncaught Throwable)
Script psalm --alter --issues=all handling the prep event returned with error code 1
Also it attempts to remove functions that it considers unused even though they're required. 👎
Also it attempts to remove functions that it considers unused even though they're required. 👎